Conversation
This was referenced Aug 29, 2025
Contributor
Author
dbanks12
force-pushed
the
db/propagate-staticness
branch
from
6910505 to
e446a77
Compare
dbanks12
requested review from
IlyasRidhuan,
Maddiaa0,
fcarreiro and
jeanmon
as code owners
jeanmon
approved these changes
Sep 1, 2025
Contributor
jeanmon
left a comment
jeanmon
left a comment
There was a problem hiding this comment.
Great little PR with good testing!
Please look at my feedback before merging.
| EXPECT_THROW_WITH_MESSAGE(check_relation<context>(trace, context::SR_IS_STATIC_IF_STATIC_CALL), | ||
| "IS_STATIC_IF_STATIC_CALL"); | ||
|
|
||
| // reset is_static |
Contributor
There was a problem hiding this comment.
Leftover? Not needed if this is the end of the test.
Contributor
Author
There was a problem hiding this comment.
I try to always "reset" mutated things like this in our cpp tests. Sometimes I do a few of them back-to-back. So this is just me trying to be consistent.
| EXPECT_THROW_WITH_MESSAGE(check_relation<context>(trace, context::SR_IS_STATIC_IF_STATIC_CALL), | ||
| "IS_STATIC_IF_STATIC_CALL"); | ||
|
|
||
| // reset is_static |
| EXPECT_THROW_WITH_MESSAGE(check_relation<context>(trace, context::SR_IS_STATIC_IF_CALL_FROM_STATIC_CONTEXT), | ||
| "IS_STATIC_IF_CALL_FROM_STATIC_CONTEXT"); | ||
|
|
||
| // reset is_static |
| EXPECT_THROW_WITH_MESSAGE(check_relation<context>(trace, context::SR_IS_STATIC_NEXT_ROW), "IS_STATIC_NEXT_ROW"); | ||
|
|
||
| // reset is_static | ||
| trace.set(C::execution_is_static, 2, 1); |
dbanks12
force-pushed
the
db/test-updates
branch
from
6fa94fa to
6ececd7
Compare
dbanks12
force-pushed
the
db/propagate-staticness
branch
from
e446a77 to
faec221
Compare
dbanks12
force-pushed
the
db/test-updates
branch
from
6ececd7 to
0a9936f
Compare
dbanks12
force-pushed
the
db/propagate-staticness
branch
2 times, most recently
from
01070a1 to
d728809
Compare
dbanks12
force-pushed
the
db/test-updates
branch
from
0a9936f to
d7b2e19
Compare
dbanks12
force-pushed
the
db/propagate-staticness
branch
from
d728809 to
206d423
Compare
…hose that are not static calls.
dbanks12
force-pushed
the
db/propagate-staticness
branch
from
206d423 to
e227523
Compare
dbanks12
force-pushed
the
db/test-updates
branch
from
d7b2e19 to
3b8db17
Compare
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
…hose that are not static calls. (#16670)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small constraints change along with some new tests.